Skip to content

fix(extension): remove redundant setOptions call before opening side panel #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcomplete merged 1 commit into from
Apr 26, 2026
Merged

fix(extension): remove redundant setOptions call before opening side panel #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions app/extension/src/background.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,18 +1022,6 @@ function openSidePanelForContextMenuClick(tab?: chrome.tabs.Tab): boolean {
return false;
}

if (typeof tab.id === "number" && typeof sidePanelApi.setOptions === "function") {
void sidePanelApi
.setOptions({
tabId: tab.id,
path: "sidepanel.html",
enabled: true,
})
.catch((error: unknown) => {
log("Failed to configure side panel:", error);
});
}

void sidePanelApi.open({ windowId: tab.windowId }).catch((error: unknown) => {
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setOptions({ tabId, path, enabled }) was the only place in this file that explicitly configured/enabled the side panel; after removing it, can you confirm the extension’s manifest/WXT build always provides the correct side_panel.default_path and that the panel is enabled by default for the target tab?
Otherwise sidePanelApi.open() may fail or open an unexpected/blank panel on Chrome versions that require setOptions to establish an active panel for the tab/window first.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

log("Failed to open side panel:", error);
});
Expand Down
Loading