Large block and item registry cleanup #11326
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical debt begone! Lots of places touched, not too many lines compared to other major refactors.
This is not going to be backported because it relies on registry features from Neoforge.
No implementation changes, only refactors! I've double checked every if condition that was touched to make sure that there weren't any accidential inversions.
Changes proposed in this pull request
DeferredRegistersrather than theRegistryEvent.ModBlockInitializerandModItemsInitializer, instead favoring the single class that both defines and assigns the registry entries at once.ModBlocksandModItemsto use new methods made available by theDeferredBlock/Itemclasses, such asModItems.item.toStack()rather thannew ItemStack(ModItems.item.get()), as well as.is()checks rather than equals checks where possible.Testing
Review please