Fix ResizeObserver errors when uploading epub files #5052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EPubJs was registering some ResizeObserver listeners when rendering the epub books, and somehow these listeners caused an infinite resize observer loop when the EPubRenderer component was unmounted. This PR destroys de epub book, which cleans these listeners, before EPubRenderer is unmounted.
Before:
Screenshare.-.2025-05-13.4_30_37.PM.mp4
After:
Screenshare.-.2025-05-13.4_31_37.PM.mp4
References
learningequality/kolibri-design-system#960
Reviewer guidance