-
Notifications
You must be signed in to change notification settings - Fork 256
[Remove Vuetify from Studio] Channel collections table #5535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Channel collections table #5535
Conversation
9a740f6 to
cc52c1e
Compare
|
Hlo @MisRob i just read the slack thread related to the Positioning of elements |
|
Hi @Prashant-thakur77, I will follow-up on everything next week. Thanks for preparing the table for this work. |
cc52c1e to
89e1c81
Compare
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Prashant-thakur77 - this is aligned to requirements, and well implemented. I'm leaving some cleanup notes.
Since we already have clarity on how the interface should look like, in addition I am also posting next steps that will actually finalize this page so we can merge this work. Those notes, however, are beyond the scope of the original issue whose main task was to prepare a draft - I consider that done. If you don't wish or can't work on those, that would be completely fine. I can finish it myself - just let me know what works best.
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Show resolved
Hide resolved
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Show resolved
Hide resolved
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Outdated
Show resolved
Hide resolved
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Outdated
Show resolved
Hide resolved
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Outdated
Show resolved
Hide resolved
| columnId: 'channel_count', | ||
| }, | ||
| { | ||
| label: '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a descriptive label here and then visually hide it? After you have installed learningequality/kolibri-design-system#1169 as suggested in the other comment, visuallyhidden class should work as expected. I think it should be possible to utilize KTable's header slot to apply the class. But this may be the first use-case - let me know if there were any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the visuallyhidden issue?should i leave this one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes yes
...entcuration/contentcuration/frontend/channelList/views/ChannelSet/StudioCollectionsTable.vue
Outdated
Show resolved
Hide resolved
...ntentcuration/frontend/channelList/views/ChannelSet/__tests__/StudioCollectionsTable.spec.js
Show resolved
Hide resolved
...ntentcuration/frontend/channelList/views/ChannelSet/__tests__/StudioCollectionsTable.spec.js
Outdated
Show resolved
Hide resolved
@MisRob I’d be happy to help further and can definitely work on the next steps as well.Firstly i will complete the necessary cleanup mentioned above. |
f2d33fc to
26fc944
Compare
|
@MisRob I have done the changes required ,and regarding one below:
I have done it by apllying -ve margin to studiocopytoken as the extra space was because of the uiFeedback box of the Ktextbox .The desired behaviour is achieved but i have not changed the 8px padding of the cells of the kTable.Do tell if it is required:) Do tell if they are according to the scope or if for the height issue some other solution is to be used:)
|
|
This all looks very good @Prashant-thakur77 |
A companion to learningequality/.github#35
Upgrade workflows to .github#35
- Related release notes: - https://github.com/learningequality/kolibri-design-system/releases/tag/v5.4.2 - https://github.com/learningequality/kolibri-design-system/releases/tag/v5.5.0 - No breaking changes - Installs the new KDS stylesheet, and removes Kolibri visuallyhidden class that is not longer needed since it's provided by KDS
|
Hi @Prashant-thakur77, all latest updates are great. I will now take this work over and fine-tune as I discuss final details with our design team. In any case, what you submitted was already very close to the final version and helped us a lot. Thanks! |
|
@MisRob glad to help, currently i am working on the side pannel pr ,but if there is any other issue you would like me to work on ,i will be glad to help:).. |




Fixes #5529
Summary
This PR replaces the old Vuetify-based ChannelSetList with a new StudioCollectionsTable built using Kolibri Design System (KDS) components. The goal is to continue the process of removing Vuetify from Studio and modernizing the UI to match current Kolibri patterns.
Screencast From 2025-11-05 11-01-24.webm
References
Sub-issue of #5060.
Reviewer guidance
How to get there
Login as [email protected] with password a
Go to Channels > Collections
How to run Kolibri
Find detailed guidance with many code examples in KDS documentation
Read #5060 for more useful references