wrong import for catch #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should import Control.Exception , not System.IO.Error Signed-off-by: JadAbouHawili <[email protected]>
JadAbouHawili
requested review from
konsumlamm,
memowe,
smith558 and
xogcox
as code owners
need Control.Exception for catch , System.IO.Error for IOError Signed-off-by: JadAbouHawili <[email protected]>
Signed-off-by: JadAbouHawili <[email protected]>
ulysses4ever
requested changes
Dec 17, 2025
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Hey @JadAbouHawili! We have just switched from HTML to Markdown. Could you please rebase (possibly re-do) you change on top of the current main branch?
ulysses4ever
added
blocked
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch is imported from Control.Exception , not System.IO.Error