You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All those files are generated by tools/extract_enum.py, each one distilled by a different C header in the PostgreSQL source. From where I stand, I see the as a single subpackage (in the sense of from pglast.enum import Foo), splitted into several sources just for convenience.
So, unless you are going to over-complicate (IMHO) the logic used by that script to emit the imports at the beginning of the generated file taking into account whether or not a particular enum subclass is used or not, manually curing each single file with no evident advantage is not going to fly.
If you have particular reasons to avoid the useless imports, I would suggest instead changing extract_enum.py so that it simply emits a single import enum at the top, and the rest of the definitions use the fully qualified enum.Foo.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes several unused imports.