Merged
Conversation
asengupta3
reviewed
Feb 25, 2026
task-launcher/serve/serve.js
Outdated
| const storeItemId = stringToBoolean(urlParams.get('storeItemId'), false); | ||
| const cat = stringToBoolean(urlParams.get('cat'), false); | ||
| const heavyInstructions = stringToBoolean(urlParams.get('heavyInstructions'), false); | ||
| const newSds = stringToBoolean(urlParams.get('newSds'), false); |
Collaborator
There was a problem hiding this comment.
I wonder if we can make this more generic. An object like:
{task: 'sds', version: 2}
This way we can move use for other tasks as well
asengupta3
approved these changes
Feb 25, 2026
Collaborator
asengupta3
left a comment
asengupta3
left a comment
There was a problem hiding this comment.
One minor comment. Other than that it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR redesigns the SDS task according to the version used by the SPARK lab. This is the documentation for their task and this is the link to the task itself. The most significant change is the addition of a side-by-side layout for the "something's the same" trials.