Open
Conversation
digital-pro
approved these changes
Mar 3, 2026
Collaborator
digital-pro
left a comment
There was a problem hiding this comment.
LGTM, or as I traditionally misread that acronym (LGTR -- Let the good times roll)
|
Looks good to me in terms of code - but do we want to consider aligning with ROAR tasks here? They're using these custom utils that draw on the detect-it package...I'm not necessarily sure it's better, but we might want to consider if/when the methods have discrepancies |
zwatson2001
approved these changes
Mar 3, 2026
Collaborator
zwatson2001
left a comment
There was a problem hiding this comment.
Looks good to me! I can test this on a few different devices before we merge, and I'm also happy to add this to H&F once we make a final decision about how to handle the instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage:
This uses: