tests/workflow: split radio_silence_persistence into its own slot#1171
Open
eriknordmark wants to merge 1 commit into
Open
tests/workflow: split radio_silence_persistence into its own slot#1171eriknordmark wants to merge 1 commit into
eriknordmark wants to merge 1 commit into
Conversation
The lps_loc scenario invokes `eden.escript.test -test.run TestEdenScripts/radio_silence`, which is a Go regex prefix match — it picks up both the `radio_silence` and `radio_silence_persistence` subtests at scenario slot 6/10. When `radio_silence_persistence` fails (e.g. NIM never settles RadioSilence.Imposed=true), the testscript runner's fail-fast policy aborts the whole suite and the remaining 4 lps_loc tests (`app_local_info`, `dev_local_info`, `publish_location`, `network_local_changes`) never run. Split them: - Slot 6 now anchors with `^radio_silence$` and only runs the passing radio_silence subtest. - A new slot 11/11 at the end runs radio_silence_persistence; a failure there no longer blocks any other test. Also fixes a label typo: slot 10's `/bin/echo` originally said "Eden location publish test" (same as slot 9). Renamed to "Eden network local changes test" to match the actual test. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eriknordmark
force-pushed
the
lps-loc-reorder-radio-silence
branch
from
465b24a to
8cac8f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
lps-locscenario invokeseden.escript.test -test.run TestEdenScripts/radio_silence, which is a Go regex prefix match — it picks up both theradio_silenceandradio_silence_persistencesubtests at scenario slot 6/10. Whenradio_silence_persistencefails (e.g. NIM never settlesRadioSilence.Imposed=true), the testscript runner's fail-fast policy aborts the whole suite and the remaining 4lps_loctests (app_local_info,dev_local_info,publish_location,network_local_changes) never run.Split them:
^radio_silence$and only runs the passingradio_silencesubtest.radio_silence_persistence; a failure there no longer blocks any other test.Also fixes a label typo: slot 10's
/bin/echooriginally said"Eden location publish test"(same as slot 9). Renamed to"Eden network local changes test"to match the actual test invoked on that line.Test plan
lps_locsuite reaches slots 7–10 even whenradio_silence_persistencefailsradio_silence(the passing one) still runs at slot 6 as beforeradio_silence_persistenceruns and reports its actual outcome at slot 11🤖 Generated with Claude Code