defaults: bump DefaultAdamTag from 0.0.75 to 0.0.79#1180
Merged
Conversation
Picks up lf-edge/adam#155, which brings the /register handler in line with the eve-api spec (APIv2.md §/register, lines 134-160): cert/serial combinations that verify cryptographically but are not in the controller's pre-registration set now return 403 Forbidden rather than 401 Unauthorized. EVE's pkg/pillar/cmd/client already maps 403 to LedBlinkOnboardingFailureNotFound, so the longstanding eve-api gap on the controller side is now closed. Pinning a specific release rather than the rolling `snapshot` tag keeps the version requirement expressible — if a future eden change needs adam ≥ x.y.z, bumping the constant is the natural way to make that explicit, and stale cached `snapshot` images on contributor machines cannot silently regress. Override at config time remains supported via `eden config set default --key=adam.tag --value=<sha-or-tag>`. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
eriknordmark
force-pushed
the
track-adam-snapshot
branch
from
1300b6c to
0f78a68
Compare
eriknordmark
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
DefaultAdamTagfrom0.0.75to0.0.79. The new release isthe first build that includes lf-edge/adam#155, which brings the
/registerhandler into compliance with the eve-api spec(APIv2.md §/register): cert + serial combinations that verify
cryptographically but are not in the controller's pre-registration
set now return 403 Forbidden instead of
401 Unauthorized. EVE'spkg/pillar/cmd/clientalready maps 403 toLedBlinkOnboardingFailureNotFound, so the longstanding controller-side eve-api gap is now closable end-to-end.
Pinning a specific release tag (rather than a rolling
snapshottag,as the initial revision of this PR proposed) keeps the version
requirement expressible — if a future eden change requires
adam ≥ x.y.z, bumping this constant is the natural way to declareit, and stale cached
snapshotimages on contributor machines cannotsilently regress. Per @milan-zededa's review point above. Override at
config time remains supported via
eden config set default --key=adam.tag --value=<sha-or-tag>.Test plan
go build ./...clean.gofmt -l pkg/defaults/defaults.goclean.make build && eden config add default && eden setup && eden startfrom a clean state pullslfedge/adam:0.0.79fromDocker Hub and brings up adam. CI should cover this.
Notes
lfedge/adam:0.0.79matches thesnapshottag and the per-SHA tag for adam master's HEAD commit
(
b27f2aa6a214a9c2f954048531a89b6876be8d50, the merge commit ofserver: return 403 on unregistered onboarding cert/serial adam#155) — verified via
hub.docker.com/v2/repositories/lfedge/adam/tags/0.0.79/.