github/zizmor: ignore legitimate audit findings#5964
Open
eriknordmark wants to merge 1 commit into
Open
Conversation
Five workflows trigger zizmor's dangerous-triggers, unpinned-uses, or
secrets-inherit audits intentionally:
- close-master-pr.yml and request_codeowners_review.yml need the
base-branch token granted by pull_request_target to post PR
metadata and request reviews. Neither checks out PR-controlled
code into a trusted context.
- pr-gate.yml, eden-trusted.yml, and cve-scan.yml run on
workflow_run after a privileged PR build completes, dispatch to
a reusable workflow inside the trust boundary, and need
privileged context to write commit statuses.
- eden-trusted.yml pins lf-edge/eden's reusable test workflow to
the release tag that matches the EVE branch (1.0.15 for the
current stable lines, master for master). Pinning to a commit
SHA would force a cross-repo bump on every eden patch release.
- publish.yml's @master reference to this repo's own assets.yml
is the documented entry point for tagged release builds.
- secrets: inherit on the eden test workflow stays within the
org-controlled trust boundary; enumerating each secret can be
done separately without changing that boundary.
Add .github/zizmor.yml with per-rule, per-path ignores covering
exactly those findings. Mechanical findings (artipacked,
excessive-permissions, template-injection, secrets-outside-env) are
not suppressed here and will be addressed in dedicated PRs.
Signed-off-by: eriknordmark <erik@zededa.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
.github/zizmor.ymlso the Zizmor workflow stops reporting theten audit findings that are legitimate by design.
The covered findings:
dangerous-triggers(5 files) —close-master-pr.ymlandrequest_codeowners_review.ymlrely onpull_request_targettouse the base-branch token for writing PR metadata; neither checks
out PR-controlled code into a trusted context.
pr-gate.yml,eden-trusted.yml, andcve-scan.ymlrun onworkflow_runaftera privileged PR build completes and need privileged context to
write commit statuses and call same-org reusable workflows.
unpinned-uses(5 references) — the four calls ineden-trusted.ymlpinlf-edge/eden's reusable test workflow tothe release tag aligned with the EVE branch (
1.0.15for currentstable lines,
masterfor master). Pinning to a commit SHA wouldforce a cross-repo bump on every eden patch release. The single
publish.yml:345reference is to this repo's ownassets.ymlat@master, which is the documented entry point for tagged releasebuilds.
secrets-inherit(4 calls, all ineden-trusted.yml) — callsthe same
lf-edge/edenreusable test workflow, inside theorg-controlled trust boundary. Enumerating the secrets explicitly
is a cosmetic change and is tracked separately.
Mechanical findings (
artipacked,excessive-permissions,template-injection,secrets-outside-env) are not suppressedhere and will be addressed in dedicated PRs.
PR dependencies
None.
How to test and validate this PR
the listed audits.
lf-edge/eveSecurity → Code scanning view aftermerge: the open-alert count should drop by the ten findings listed
above (5
dangerous-triggers, 5unpinned-usesreferences / 7alert rows minus the two we intentionally left open, and 4
secrets-inherit). Thecve-scan.yml:17andclaude-review.yml:46unpinned-usesalerts are deliberately not suppressed.the same steps.
Changelog notes
None. CI-only change.
PR Backports
Checklist