Fix: prevent unexpected connection info string#845
Closed
k-jun wants to merge 2 commits intolib:masterfrom
k-jun:add_error_handling_for_connection_string
Closed
Fix: prevent unexpected connection info string#845k-jun wants to merge 2 commits intolib:masterfrom k-jun:add_error_handling_for_connection_string
k-jun wants to merge 2 commits intolib:masterfrom
k-jun:add_error_handling_for_connection_string
Conversation
Collaborator
|
Seems to work in a quick test? Outputs |
Collaborator
|
As near as I can tell this behaves correctly, so either this has already been fixed since this PR was opened or one of us is mistaken. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a problem when I am using this library and this PR is to fix that.
My code is something like that.
if the password info was not provided or "", the driver gave me an error.
I know this is because the password is blank and following part (in this case "dbname") is handled as a password value, and instead of that, the username was used as a database name.
this is an expected behavior as I could see from the test code, like
but I thought to check if the value contains "=" and if so, add new key is better.
This is my first time to make PR so maybe I am saying something stupid, so if there are any strange points please let me know.
Thanks