Try fix occasional benchmark file decompression failures #1442
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For longer running benchmarks we download an xz compressed archive containing debug data for a certain kernel version. In recent times the decompression has started failing in CI, for no apparent reason. Local reproduction has failed. Looking at the code, it seems possible that we experienced short write during download and then discarded the unwritten rest. Switch from using std::io::Write::write() to std::io::Write::write_all() in an attempt to fix this issues. Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 61 61
Lines 11114 11114
=======================================
Hits 10648 10648
Misses 466 466 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For longer running benchmarks we download an xz compressed archive containing debug data for a certain kernel version. In recent times the decompression has started failing in CI, for no apparent reason. Local reproduction has failed.
Looking at the code, it seems possible that we experienced short write during download and then discarded the unwritten rest. Switch from using
std::io::Write::write()tostd::io::Write::write_all()in an attempt to fix this issues.