Return null on rawIspInfo instead of '' when data not available

[zimbres]

This is to avoid the wrong format of message:

You're testing from: {"processedString":"172.17.0.1 - private IPv4 access","rawIspInfo":""}

[sstidl]

This is to avoid the wrong format of message:

You're testing from: {"processedString":"172.17.0.1 - private IPv4 access","rawIspInfo":""}

Which wrong format message are you referring to?

We are planning to release the next version soon and did refactor the same file, please check branch ipinfo_offlinedb

[zimbres]

Lets say, using cli, testing against a local server with the change proposed, a far server with default docker image, and a public test

Marcio@Tower  /d/speedtes-cli
$ ./librespeed-cli.exe --local-json server.json --server 2 --telemetry-json telemetry.json 
Using local JSON server list: server.json
Selected server: Far [far]
You're testing from: {"processedString":"10.10.10.1 - private IPv4 access","rawIspInfo":""}
Ping: 144.45 ms Jitter: 1.05 ms
Download rate:  150.07 Mbps     
Upload rate:    41.46 Mbps   
Share your result: http://localhost:8080/results/?id=9

Marcio@Tower  /d/speedtes-cli
$ ./librespeed-cli.exe --local-json server.json --server 1 --telemetry-json telemetry.json
Using local JSON server list: server.json
Selected server: Local [localhost]
You're testing from: 172.17.0.1 - private IPv4 access
Ping: 1.00 ms   Jitter: 0.00 ms
Download rate:  1042.32 Mbps     
Upload rate:    927.02 Mbps    
Share your result: http://localhost:8080/results/?id=10

Marcio@Tower  /d/speedtes-cli
$ ./librespeed-cli.exe
Retrieving server list from https://librespeed.org/backend-servers/servers.php
Selecting the fastest server based on ping
Selected server: Atlanta, United States (Clouvider) [atl.speedtest.clouvider.net]
Sponsored by: Clouvider @ https://www.clouvider.co.uk/
You're testing from: 178.81.81.75 - Unknown ISP
Ping: 139.82 ms Jitter: 1.41 ms
Download rate:  134.39 Mbps     
Upload rate:    16.16 Mbps   

[sstidl]

Thank you for the example of usage but I still don't see what the problem is

[sstidl]

@adolfintel would this change break anything? The UI seems to handle the empty string correctly. But will it handle a null value as well?

[adolfintel]

@sstidl I don't understand the use case either. I made it return an empty string instead of null specifically to avoid "accidental" null pointers, can't you just check if the string is empty?

[zimbres]

When the test is performed on public librespeed.org, the value is null as well

[adolfintel]

The empty rawIspInfo string was introduced in 2020, not all the public backend servers are ours, clearly this one hasn't been updated in ages.

[zimbres]

So the problem might be on cli not able to parse the json correclty when comes "" instead of null?
I could not go deeper in the "go" stuff