feat(@clayui/autocomplete): LPD-66892 Add selectedKeys prop to improve selected state #6208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iSelect Autocomplete
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MarioLeandro
commented
Nov 13, 2025
|
|
||
| /** | ||
| * Flag that indicates if item is selected. | ||
| * @deprecated since v3.151.0 - uses the `selectedKeys` property on the |
Member
Author
There was a problem hiding this comment.
@ethib137 The version here should be the one from clay-autocomplete/package.json ?
limaagabriel
requested changes
Nov 13, 2025
…hat were using the old aria-selected behavior
…button' instead of 'li'
… is selected test
…erty to accept options of type number
…ibility to Autocomplete.Item
…ls selected state feedback only if selectedKeys is defined and includes the item
…yAutocomplete.Item because it is no longer needed due to the use of `selectKeys` in the root component.
MarioLeandro
force-pushed
the
LPD-66892
branch
from
fce7634 to
07092ae
Compare
Member
Author
|
Hey @limaagabriel. I've implemented some changes based on your feedback. Let me know what you think. |
limaagabriel
approved these changes
Nov 14, 2025
pat270
approved these changes
Nov 17, 2025
|
|
||
| /** | ||
| * Flag that indicates if item is selected. | ||
| * @deprecated since v3.151.0 - uses the `selectedKeys` property on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA-Ticket: https://liferay.atlassian.net/browse/LPD-66892
Motivation
Currently, the Autocomplete does not provide a clear selected state in its menu. Unlike the Picker (which uses a dark check), users cannot visually confirm which item is active once the menu is open. This creates confusion, especially when dealing with long lists of items.
Solution
aria-selectedattribute is now linked to whether the item is selected or not, and no longer to whether the item is in focus. This change follows the item pattern of the Picker component.aria-selectedbehavior have been modified to match the new version.1. Selected State - Autocomplete
Show the visual feedback for selected items.
1. Selected State - Multiselect
Show the visual feedback for selected items.
1. selectedKeys(clayui.com) Example - Autocomplete
Show the visual feedback for selected items.
1. API Reference - Autocomplete
The new properties added.