LRCI-5884

[pyoo47]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @pyoo47, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness and consistency of the Playwright testing infrastructure by centralizing WebLogic server setup logic into a dedicated Ant target and integrating it directly into the server startup script. Furthermore, it standardizes the application server shutdown procedures, making them more reliable and correcting a previous operational error for WebLogic.

Highlights

• New WebLogic Setup Target: A new Ant target, setup-weblogic-playwright, has been introduced in build-test-weblogic.xml to encapsulate and standardize the configuration steps required for WebLogic application servers within the Playwright testing environment.
• Automated WebLogic Environment Preparation: The start_app_server function in modules/test/playwright/env/common.sh now automatically invokes the setup-weblogic-playwright Ant target when a WebLogic server is being started, ensuring that the environment is correctly prepared before the server fully launches.
• Standardized Application Server Shutdown: The stop_app_server function in modules/test/playwright/env/common.sh has been refactored to streamline the shutdown process. Tomcat servers continue to use their specific shutdown.sh script, while all other application server types (including WebLogic, JBoss, and Wildfly) now utilize a common stop-app-server Ant target from build-test.xml. This change also corrects an issue where WebLogic was previously being started instead of stopped during the shutdown sequence.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces setup logic for running Playwright tests with WebLogic and refactors the application server stop logic. A new Ant target setup-weblogic-playwright is added, and the common.sh script is updated to use it. The server stop logic is also simplified, fixing a critical bug for WebLogic. My review found a critical issue in common.sh where an ant command is run from an incorrect directory, which would cause the script to fail. I have also included a suggestion to improve the performance of the new Ant target.

[gemini-code-assist]

This ant command will fail because it's executed from the wrong directory. The start_app_server function changes the current directory to the app server's bin directory, but the build-test-weblogic.xml file is located at the project root (${_PORTAL_PROJECT_DIR}). You need to change to the project root before executing ant. Using a subshell (...) is recommended to avoid side effects on subsequent commands.

Suggested change

	ant -f build-test-weblogic.xml setup-weblogic-playwright
	(cd ${_PORTAL_PROJECT_DIR} && ant -f build-test-weblogic.xml setup-weblogic-playwright)

[gemini-code-assist]

The use of multiple consecutive <antcall> tasks is inefficient because each call creates a new Ant project instance, which can negatively impact build performance. For better performance and maintainability, consider refactoring this to use target dependencies (depends attribute) to create an execution chain. If modifying the dependency targets is not an option, you could create wrapper targets to define the sequence.