Skip to content

Conversation

@benthecarman
Copy link
Contributor

We currently have the SqliteStore public so others can use it outside of just their ldk-node wallet but did not do the same for the VssStore. This makes it public along with the 2 derivation path consts used when deriving the keys so people can more easily replicate the key schema as well

We currently have the `SqliteStore` public so others can use it outside
of just their ldk-node wallet but did not do the same for the
`VssStore`. This makes it public along with the 2 derivation path consts
used when deriving the keys so people can more easily replicate the key
schema as well
@benthecarman benthecarman requested a review from tnull November 20, 2025 16:25
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 20, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@benthecarman benthecarman changed the title pub vss Make VssStore public Nov 20, 2025
@benthecarman benthecarman self-assigned this Nov 20, 2025
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as mentioned offline this needs to be part of a larger refactor that also allows to reuse the node secret/entropy source in a reasonable way, for which I'm close ot have a branch ready. I don't think we should just expose VssStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants