Skip to content

Backport 4234 to 0.2 #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 0.2
Choose a base branch
from
Open

Backport 4234 to 0.2 #4239

wants to merge 2 commits into from
+76 −5

Conversation

@benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Nov 21, 2025

Backports #4234

@benthecarman
Add funding redeem script to ChannelDetails and ChannelPending event
734bc6a 
Original context and motivation comes from here: lightningdevkit/ldk-node#677 (comment)

When splicing-in, the default case is our channel utxo + our wallet utxos
being combined. This works great however, it can give our wallet issues
calculating fees after the fact because our wallet needs to know about
our channel's utxo. We currently have it's outpoint and satoshi value
available, but not its output script so we are unable to construct the
TxOut for the channel. This adds the redeem script to the
`ChannelDetails` and `ChannelPending` event which gives us enough
information to be able to construct it.
@benthecarman
Add funding redeem script to `SplicePending' event
6e6e4c2
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 21, 2025 •
edited
Loading

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.85%. Comparing base (e2ca5ba) to head (6e6e4c2).

Files with missing lines Patch % Lines
lightning/src/ln/channel_state.rs 46.66% 8 Missing ⚠️
lightning/src/routing/router.rs 50.00% 4 Missing ⚠️
lightning/src/ln/channelmanager.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              0.2    #4239      +/-   ##
==========================================
- Coverage   88.87%   88.85%   -0.02%     
==========================================
  Files         180      180              
  Lines      138000   138039      +39     
  Branches   138000   138039      +39     
==========================================
+ Hits       122642   122659      +17     
- Misses      12534    12559      +25     
+ Partials     2824     2821       -3
Flag Coverage Δ
fuzzing 20.85% <46.66%> (-0.58%) ⬇️
tests 88.70% <69.04%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpaulino
wpaulino approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheBlueMatt up to you if you want to include it this late in the cycle

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 21, 2025

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpaulino wpaulino wpaulino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benthecarman @ldk-reviews-bot @wpaulino