Skip to content

Conversation

@andrei-21
Copy link
Contributor

So that Storable::encode_to_vec() can be used without requiring users to depend on the exact same prost version as vss-client.

@jkczyz jkczyz requested a review from tnull November 12, 2025 17:11
So that `Storable::encode_to_vec()` can be used without requiring
users to depend on the exact same prost version as vss-client.
@@ -1,5 +1,5 @@
use crate::types::{EncryptionMetadata, PlaintextBlob, Storable};
use ::prost::Message;
pub use ::prost::Message;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than doing that for just Message, let's just re-export the prost crate we're using in lib.rs, just as we recently did with reqwest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@andrei-21 andrei-21 force-pushed the feature/re-export-prost-message branch from 07f0d4e to f26e529 Compare November 13, 2025 10:18
@andrei-21 andrei-21 changed the title Re-export prost::Message Re-export prost Nov 13, 2025
@tnull tnull merged commit 5934149 into lightningdevkit:main Nov 13, 2025
4 checks passed
@andrei-21 andrei-21 deleted the feature/re-export-prost-message branch November 13, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants