Add example Dockerfile to build the remote signer #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Dockerfile to the example remote signing server so the example could be deployed to a cloud infra. Converge ENV names used in the remote signer to the Lightspark standard. Towards LPT-224
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| COPY --from=builder /usr/src/remote-signer/target/release/lightspark-remote-signing-server /usr/local/bin/remote-signing-server | ||
|
|
||
| # Install security updates | ||
| RUN apt-get update && apt-get -y upgrade && apt-get clean && rm -rf /var/lib/apt/lists |
There was a problem hiding this comment.
The rm -rf /var/lib/apt/lists command is missing the trailing wildcard. To properly clean up all files in the apt lists directory, please update to:
RUN apt-get update && apt-get -y upgrade && apt-get clean && rm -rf /var/lib/apt/lists/*
This ensures complete cleanup of package metadata after the upgrade.
Suggested change
| RUN apt-get update && apt-get -y upgrade && apt-get clean && rm -rf /var/lib/apt/lists | |
| RUN apt-get update && apt-get -y upgrade && apt-get clean && rm -rf /var/lib/apt/lists/* |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
There was a problem hiding this comment.
pretty sure rm -rf does not need a trailing wildcard
zhenlu
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Dockerfile to the example remote signing server so the example could be deployed to a cloud infra. Converge ENV names used in the remote signer to the Lightspark standard.
Towards LPT-224