Skip to content

Conversation

@zhihaodev
Copy link
Contributor

@zhihaodev zhihaodev commented Jul 18, 2025

Test failures in github action: https://github.com/linkedin/parseq/actions/runs/16303725941/job/46050223728

The current test testStaticWithSideEffectFullCompletion assert that the task is not done immediately after invoking run:

    Task<Void> sideEffect = Task.withSideEffect(() -> slowSideEffect);
    run(sideEffect);
    assertFalse(sideEffect.isDone());

However, this may not be true in all environments and looks like in github action the task can be completed faster.
Removing the assertion to make the test stable in github action.

@zhihaodev zhihaodev changed the title Enable info logs and stack trace in github action Fix flaky test testStaticWithSideEffectFullCompletion Jul 18, 2025
@zhihaodev zhihaodev marked this pull request as ready for review July 18, 2025 20:46
@zhihaodev zhihaodev merged commit ae967ef into master Jul 18, 2025
2 checks passed
@zhihaodev zhihaodev deleted the debug-ci branch July 18, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants