Skip to content

Regression fixes#856

Open
mawilk90 wants to merge 6 commits intolinode:devfrom
mawilk90:hotfix/TPT_4203_regression
Open

Regression fixes#856
mawilk90 wants to merge 6 commits intolinode:devfrom
mawilk90:hotfix/TPT_4203_regression

Conversation

@mawilk90
Copy link
Contributor

📝 Description

Regression fixes for integration tests. Most of the failures were possibly related to long domain creation ([404] Not found, timeout)

Jira: https://track.akamai.com/jira/browse/TPT-4203

✔️ How to Test

Integration tests workflow run

@mawilk90 mawilk90 marked this pull request as ready for review February 17, 2026 12:11
@mawilk90 mawilk90 requested a review from a team as a code owner February 17, 2026 12:11
@mawilk90 mawilk90 requested review from Copilot, psnoch-akamai, vshanthe, yec-akamai and zliang-akamai and removed request for a team February 17, 2026 12:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses regression failures in integration tests that were caused by timing issues during domain creation. The changes add polling mechanisms to wait for domains to become active before proceeding with tests, preventing 404 errors and timeouts.

Changes:

  • Extended object storage cluster status validation to include "hidden" and "limited" states
  • Enhanced wait_for_condition helper to accept variable arguments for more flexible condition checking
  • Added view_command_attribute helper utility for retrieving specific attributes from CLI commands
  • Implemented domain status polling in domain and event fixtures to ensure domains are active before test execution
  • Added proper cleanup for test-created domains to prevent resource leakage

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/integration/obj/test_object_storage.py Added "hidden" and "limited" to valid cluster status values
tests/integration/helpers.py Enhanced wait_for_condition to accept *args and added view_command_attribute helper
tests/integration/events/fixtures.py Added domain status polling with wait_for_condition to events_create_domain fixture
tests/integration/domains/test_domain_records.py Added cleanup for test-created domain and imported delete_target_id
tests/integration/domains/fixtures.py Added domain status polling to all domain fixtures (master_domain, slave_domain, domain_and_record)
Comments suppressed due to low confidence (1)

tests/integration/helpers.py:73

  • The error message "SSH timeout expired" is misleading when this function is used for waiting on domain status. The function is now generic and accepts any condition via the condition parameter, so the error message should be more generic or customizable. Consider changing the message to something like "Timeout waiting for condition" or accepting a custom timeout message as a parameter.
        if time.time() - start_time > timeout:
            raise TimeoutError("SSH timeout expired")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant