fix: exclude gosec G117 for golangci-lint > 2.9#898
fix: exclude gosec G117 for golangci-lint > 2.9#898glennpratt wants to merge 2 commits intolinode:mainfrom
Conversation
glennpratt
requested review from
vshanthe and
yec-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR addresses a regression introduced by golangci-lint 2.10, which is automatically used in CI due to the version: latest configuration. The PR adds an exclusion for gosec rule G117, which detects potential hardcoded credentials by flagging variables and fields containing "secret" in their names. The codebase has legitimate API response fields like OAuthClient.Secret, TwoFactorSecret.Secret, and ObjectStorageKey.SecretKey that trigger false positives for this rule.
Changes:
- Adds exclusion rule in
.golangci.ymlto suppress gosec G117 warnings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
New regression with golangci-lint 2.10 which is automatically used because tests target latest.