style(hotspot): optimize hotspot dialog UI appearance#543
style(hotspot): optimize hotspot dialog UI appearance#543deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the hotspot dialog’s visual styling by making the dialog background transparent and updating the Save control to use the standardized recommended button component for better UI consistency. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Using a fully transparent dialog background may hurt readability when the underlying content is visually busy; consider using a themed background with partial opacity (or following whatever pattern other dialogs in this app use) to maintain contrast while still lightening the UI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using a fully transparent dialog background may hurt readability when the underlying content is visually busy; consider using a themed background with partial opacity (or following whatever pattern other dialogs in this app use) to maintain contrast while still lightening the UI.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
dcc-network/qml/PageHotspot.qml
Outdated
|
|
||
| modality: Qt.ApplicationModal | ||
| width: 380 | ||
| color: "transparent" |
There was a problem hiding this comment.
这个应该在dtk里修一下吧,另外防止去掉了窗口模糊后背景不对的问题,参照这种修改下,https://github.com/linuxdeepin/dde-shell/blob/f4f526260a764bcc5e811b60d8273edc45ca35f6/panels/dock/package/main.qml#L400
There was a problem hiding this comment.
change save button to recommended button style for better visual consistency. 添加透明背景并将保存按钮改为推荐按钮样式。 Log: 优化热点对话框UI PMS: BUG-316567 Influence: 热点对话框界面更加美观统一,提升用户体验。
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Add transparent background to hotspot dialog and change save button to recommended button style for better visual consistency.
添加透明背景并将保存按钮改为推荐按钮样式。
Log: 优化热点对话框UI
PMS: BUG-316567
Influence: 热点对话框界面更加美观统一,提升用户体验。
Summary by Sourcery
Refine the hotspot configuration dialog appearance for a more consistent and polished UI.
Enhancements: