fix: leaderboard collection filter #1452
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gašper Grom <[email protected]>
Copilot finished reviewing on behalf of
gaspergrom
November 28, 2025 11:04
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the leaderboard collection filter by ensuring proper default values and consistent sorting behavior. The changes align the default collection filter with the "All collections" option and improve the UI consistency.
- Changed the default collection slug from empty string to 'all' to match the dropdown's "All collections" option
- Added sort parameter to collection search API to ensure starred collections appear first
- Made minor UI adjustments to button size and dropdown layout styling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| leaderboard-detail-header.vue | Updated button size to medium and changed default collection slug to 'all' |
| collections-filter.vue | Added flex layout styling to dropdown content wrapper |
| collections.api.service.ts | Added 'starred_desc' sort parameter to searchCollections method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.