Fix format for helm_version input for helm-chart-oci-publisher
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We define HELM_VERSION wrong across different LFX v2 workflows, but this was the first one to try and actually use it, and our format was wrong for this job. Signed-off-by: Eric Searcy <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes the format of the HELM_VERSION environment variable by removing the v prefix, changing it from v4.0.1 to 4.0.1. This correction ensures compatibility with the helm-chart-oci-publisher action used in the workflow, which expects the version without the prefix.
Key changes:
- Corrected
HELM_VERSIONformat fromv4.0.1to4.0.1to match the expected input format forhelm-chart-oci-publisher
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrest50
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We define HELM_VERSION wrong across different LFX v2 workflows, but this was the first one to try and actually use it, and our format was wrong for this job.
See: https://github.com/linuxfoundation/lfx-public-workflows/blob/main/.github/actions/helm-chart-oci-publisher/action.yml#L37-L40 (default has no "v" prefix)