-
Notifications
You must be signed in to change notification settings - Fork 0
first batch of polishing touches #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||||||||||||||||||||||
| <section data-testid="foundation-health-section"> | ||||||||||||||||||||||||||
| <div class="flex items-center justify-between mb-4"> | ||||||||||||||||||||||||||
| <div class="flex flex-col md:flex-row md:items-center gap-3"> | ||||||||||||||||||||||||||
| <h2 class="font-['Roboto_Slab'] font-semibold text-[16px]">{{ title() }}</h2> | ||||||||||||||||||||||||||
| <h2>{{ title() }}</h2> | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| <!-- Filter Pills --> | ||||||||||||||||||||||||||
| <lfx-filter-pills | ||||||||||||||||||||||||||
|
|
@@ -36,15 +36,25 @@ <h2 class="font-['Roboto_Slab'] font-semibold text-[16px]">{{ title() }}</h2> | |||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| <!-- Carousel Container --> | ||||||||||||||||||||||||||
| <div class="overflow-hidden"> | ||||||||||||||||||||||||||
| <div #carouselScroll class="flex gap-4 overflow-x-auto pb-2 hide-scrollbar scroll-smooth" data-testid="foundation-health-carousel"> | ||||||||||||||||||||||||||
| <div class="relative overflow-hidden"> | ||||||||||||||||||||||||||
| <!-- Left Fade Gradient --> | ||||||||||||||||||||||||||
| @if (canScrollLeft()) { | ||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| <!-- Right Fade Gradient --> | ||||||||||||||||||||||||||
| @if (canScrollRight()) { | ||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||
|
Comment on lines
+42
to
+47
|
||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);"></div> | |
| } | |
| <!-- Right Fade Gradient --> | |
| @if (canScrollRight()) { | |
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);"></div> | |
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> | |
| } | |
| <!-- Right Fade Gradient --> | |
| @if (canScrollRight()) { | |
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> |
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||||||||||||||||||||||||||
| <section class="flex flex-col flex-1" data-testid="dashboard-my-meetings-section"> | ||||||||||||||||||||||||||||||
| <!-- Header --> | ||||||||||||||||||||||||||||||
| <div class="flex items-center justify-between mb-4"> | ||||||||||||||||||||||||||||||
| <h2 class="font-display font-semibold text-gray-900">My Meetings</h2> | ||||||||||||||||||||||||||||||
| <h2>My Meetings</h2> | ||||||||||||||||||||||||||||||
| <lfx-button | ||||||||||||||||||||||||||||||
| label="View All" | ||||||||||||||||||||||||||||||
| icon="fa-light fa-chevron-right" | ||||||||||||||||||||||||||||||
|
|
@@ -17,19 +17,29 @@ <h2 class="font-display font-semibold text-gray-900">My Meetings</h2> | |||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| <!-- Scrollable Content --> | ||||||||||||||||||||||||||||||
| <div class="flex flex-col flex-1"> | ||||||||||||||||||||||||||||||
| <div class="relative flex flex-col flex-1 -my-1"> | ||||||||||||||||||||||||||||||
| @if (loading()) { | ||||||||||||||||||||||||||||||
| <div class="flex flex-col gap-3" data-testid="dashboard-my-meetings-loading"> | ||||||||||||||||||||||||||||||
| <p-skeleton width="100%" height="140px"></p-skeleton> | ||||||||||||||||||||||||||||||
| <p-skeleton width="100%" height="140px"></p-skeleton> | ||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||
| } @else { | ||||||||||||||||||||||||||||||
| <div class="flex flex-col gap-6 overflow-scroll max-h-[30rem]" data-testid="dashboard-my-meetings-list"> | ||||||||||||||||||||||||||||||
| <!-- Top Fade Gradient --> | ||||||||||||||||||||||||||||||
| @if (canScrollUp()) { | ||||||||||||||||||||||||||||||
| <div class="absolute top-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to bottom, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| <!-- Bottom Fade Gradient --> | ||||||||||||||||||||||||||||||
| @if (canScrollDown()) { | ||||||||||||||||||||||||||||||
| <div class="absolute bottom-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to top, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||||||
|
Comment on lines
+29
to
+34
|
||||||||||||||||||||||||||||||
| <div class="absolute top-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to bottom, #f8f8f9 0%, transparent 100%);"></div> | |
| } | |
| <!-- Bottom Fade Gradient --> | |
| @if (canScrollDown()) { | |
| <div class="absolute bottom-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to top, #f8f8f9 0%, transparent 100%);"></div> | |
| <div class="absolute top-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to bottom, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> | |
| } | |
| <!-- Bottom Fade Gradient --> | |
| @if (canScrollDown()) { | |
| <div class="absolute bottom-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to top, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gradient overlay div lacks an aria-hidden="true" attribute. Since this is a purely decorative element that serves no semantic purpose, it should be hidden from assistive technologies to avoid confusion.
| <div class="absolute bottom-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to top, #f8f8f9 0%, transparent 100%);"></div> | |
| <div class="absolute bottom-0 left-0 right-0 h-16 pointer-events-none z-10" style="background: linear-gradient(to top, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The h4 element has text-gray-500 class which will override the default typography styles defined in styles.scss. The new global styles target elements without text- or font- classes using :not([class*='text-']):not([class*='font-']). Consider removing the explicit text color class to let the default h4 styles apply, or keep it intentionally for specific styling. Additionally, the removed classes (text-xs font-medium uppercase tracking-wide) provided specific styling that is now lost - verify this is the intended visual outcome.
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The h4 element has text-gray-500 class which will override the default typography styles defined in styles.scss. The new global styles target elements without text- or font- classes using :not([class*='text-']):not([class*='font-']). Consider removing the explicit text color class to let the default h4 styles apply, or keep it intentionally for specific styling. Additionally, the removed classes (text-xs font-medium uppercase tracking-wide) provided specific styling that is now lost - verify this is the intended visual outcome.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |||||||||||||||||||||||||||||
| <section data-testid="dashboard-organization-involvement-section"> | ||||||||||||||||||||||||||||||
| <div class="flex items-center justify-between mb-4"> | ||||||||||||||||||||||||||||||
| <div class="flex flex-col md:flex-row md:items-center gap-3"> | ||||||||||||||||||||||||||||||
| <h2 class="font-['Roboto_Slab'] font-semibold text-[16px]">{{ accountName() }}'s Involvement</h2> | ||||||||||||||||||||||||||||||
| <h2>{{ accountName() }}'s Involvement</h2> | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| <!-- Filter Pills --> | ||||||||||||||||||||||||||||||
| <lfx-filter-pills [options]="filterOptions" [selectedFilter]="selectedFilter()" (filterChange)="handleFilterChange($event)"></lfx-filter-pills> | ||||||||||||||||||||||||||||||
|
|
@@ -49,18 +49,28 @@ <h2 class="font-['Roboto_Slab'] font-semibold text-[16px]">{{ accountName() }}'s | |||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||
| } @else { | ||||||||||||||||||||||||||||||
| <div class="overflow-hidden"> | ||||||||||||||||||||||||||||||
| <div #carouselScroll class="flex gap-4 overflow-x-auto pb-2 hide-scrollbar scroll-smooth" data-testid="dashboard-involvement-carousel"> | ||||||||||||||||||||||||||||||
| <div class="relative overflow-hidden"> | ||||||||||||||||||||||||||||||
| <!-- Left Fade Gradient --> | ||||||||||||||||||||||||||||||
| @if (canScrollLeft()) { | ||||||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| <!-- Right Fade Gradient --> | ||||||||||||||||||||||||||||||
| @if (canScrollRight()) { | ||||||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);"></div> | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);"></div> | |
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gradient overlay div lacks an aria-hidden="true" attribute. Since this is a purely decorative element that serves no semantic purpose, it should be hidden from assistive technologies to avoid confusion.
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);"></div> | |
| } | |
| <!-- Right Fade Gradient --> | |
| @if (canScrollRight()) { | |
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);"></div> | |
| <div class="hidden md:block absolute top-0 bottom-0 left-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to right, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> | |
| } | |
| <!-- Right Fade Gradient --> | |
| @if (canScrollRight()) { | |
| <div class="hidden md:block absolute top-0 bottom-0 right-0 w-24 pointer-events-none z-10" style="background: linear-gradient(to left, #f8f8f9 0%, transparent 100%);" aria-hidden="true"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gradient overlay div lacks an
aria-hidden="true"attribute. Since this is a purely decorative element that serves no semantic purpose, it should be hidden from assistive technologies to avoid confusion.