XAppIconChooserDialog: Subclass GtkDialog, not XAppGtkWindow. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwebster
changed the title
This was referenced Jan 15, 2026
clefebvre
changed the title
The way we implement dialog.run() was causing issues when spawned from another dialog with its own event loop. This lets us rely on GtkDialog's handling for this, and allows us to run it non-blocking, and have a 'response' signal like any other dialog.
mtwebster
force-pushed
the
icon-chooser-dialog-to-dialog
branch
from
27f1108 to
e0a3fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we implement dialog.run() was causing issues when spawned from another dialog with its own event loop.
This lets us rely on GtkDialog's handling for this, and allows us to run it non-blocking, and have a 'response' signal like any other dialog.