Skip to content

Conversation

@prakhar14-op
Copy link

@prakhar14-op prakhar14-op commented Oct 28, 2025

Fixes #5293

Proposed Changes

Updated the ChaosFaults.tsx component to conditionally display the VMware logo for fault cards belonging to the 'VMware' category. This replaces the default LitmusChaos logo for VMware cards, as requested in the issue, improving visual consistency with other cloud provider categories.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed. (Maintainers usually check this)
  • Lint and unit tests pass locally with my changes (Assuming the lint-staged check during commit passed)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@prakhar14-op prakhar14-op force-pushed the fix/vmware-fault-card-logo branch from 9f2bb0b to b89cb20 Compare October 28, 2025 17:49
@PriteshKiri
Copy link
Contributor

Hey @prakhar14-op

Could you please share the screenshot of the updated UI?

@amityt
Copy link
Contributor

amityt commented Oct 29, 2025

Hi @prakhar14-op Thanks for the contribution! One small suggestion: could you use an SVG instead of a PNG? PNGs can appear blurry on some screens, while SVGs scale cleanly at any resolution.

@prakhar14-op
Copy link
Author

Hi @prakhar14-op Thanks for the contribution! One small suggestion: could you use an SVG instead of a PNG? PNGs can appear blurry on some screens, while SVGs scale cleanly at any resolution.

ya sure

@PriteshKiri
Copy link
Contributor

Hey @prakhar14-op

Could you please resolve the conflicts? Please refer this PR for the same

@prakhar14-op
Copy link
Author

Ok I will do > Hey @prakhar14-op

Could you please resolve the conflicts? Please refer this PR for the same

@prakhar14-op prakhar14-op force-pushed the fix/vmware-fault-card-logo branch from 1f197bf to ace30b8 Compare October 30, 2025 16:20
@prakhar14-op
Copy link
Author

hi @PriteshKiri i had done the changes plz check and if there is something to change the let me know , i will do those changes .

@prakhar14-op prakhar14-op requested a review from amityt October 31, 2025 05:24
@PriteshKiri
Copy link
Contributor

Hey @prakhar14-op

Could you please delete the hardcoded image and keep the image link as done in the PR i shared in previous comment?

@prakhar14-op
Copy link
Author

Ya sure > Hey @prakhar14-op

Could you please delete the hardcoded image and keep the image link as done in the PR i shared in previous comment?

@prakhar14-op
Copy link
Author

hi @PriteshKiri is it correct now ?

@PriteshKiri
Copy link
Contributor

I think it's still the same. Could you please check if you've pushed the changes?

@prakhar14-op prakhar14-op force-pushed the fix/vmware-fault-card-logo branch from 35e1002 to a71690e Compare October 31, 2025 12:52
@prakhar14-op
Copy link
Author

hi @PriteshKiri i had done this , please check

@PriteshKiri
Copy link
Contributor

Hey @prakhar14-op,
Could you please resolve the conflicts? Since multiple issues touch the same file, merging some PRs is causing conflicts in others.

@prakhar14-op
Copy link
Author

Ok I will do the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Litmus Logo with VMware Logo in Chaos Fault Cards inside ChaosCenter

3 participants