-
Notifications
You must be signed in to change notification settings - Fork 780
feat(chaoshub): replace litmus logo with vmware logo on fault card #5298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(chaoshub): replace litmus logo with vmware logo on fault card #5298
Conversation
9f2bb0b to
b89cb20
Compare
|
Hey @prakhar14-op Could you please share the screenshot of the updated UI? |
|
Hi @prakhar14-op Thanks for the contribution! One small suggestion: could you use an SVG instead of a PNG? PNGs can appear blurry on some screens, while SVGs scale cleanly at any resolution. |
ya sure |
|
Hey @prakhar14-op Could you please resolve the conflicts? Please refer this PR for the same |
|
Ok I will do > Hey @prakhar14-op
|
1f197bf to
ace30b8
Compare
|
hi @PriteshKiri i had done the changes plz check and if there is something to change the let me know , i will do those changes . |
|
Hey @prakhar14-op Could you please delete the hardcoded image and keep the image link as done in the PR i shared in previous comment? |
|
Ya sure > Hey @prakhar14-op
|
|
hi @PriteshKiri is it correct now ? |
|
I think it's still the same. Could you please check if you've pushed the changes? |
Signed-off-by: Prakhar Sharma <[email protected]>
35e1002 to
a71690e
Compare
|
hi @PriteshKiri i had done this , please check |
|
Hey @prakhar14-op, |
|
Ok I will do the changes |
Fixes #5293
Proposed Changes
Updated the
ChaosFaults.tsxcomponent to conditionally display the VMware logo for fault cards belonging to the 'VMware' category. This replaces the default LitmusChaos logo for VMware cards, as requested in the issue, improving visual consistency with other cloud provider categories.Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.lint-stagedcheck during commit passed)