Skip to content

24 better urls concatenation #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
litteratum merged 2 commits into from
Feb 26, 2026
Merged

24 better urls concatenation #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea24f1
24: better URLs concatenation
Feb 26, 2026
2b12a89
24: dependencies update
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions httprest/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def __init__(
:param http_client: HTTP client to use for making HTTP requests.
If not provided, the default one will be used
"""
self._base_url = base_url.rstrip("/")
self._base_url = base_url.rstrip("/") + "/"
self._http_client = http_client or _UrllibHTTPClient()

def _request(
Expand Down Expand Up @@ -59,7 +59,9 @@ def _request(
)

def _build_url(self, endpoint: _Optional[str]) -> str:
return urllib.parse.urljoin(self._base_url, endpoint)
return urllib.parse.urljoin(
self._base_url, endpoint.lstrip("/") if endpoint else ""
)

def __str__(self) -> str:
return f"{self.__class__.__name__}(base_url='{self._base_url}')"
Loading