feat(metrics): add generation_tokens_total and prompt_tokens_total metrics #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mayabar
requested changes
Dec 7, 2025
googs1025
force-pushed
the
add/counter
branch
2 times, most recently
from
100bb9f to
b49b40b
Compare
mayabar
requested changes
Dec 8, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
Added some comments regarding buckets limits
googs1025
force-pushed
the
add/counter
branch
2 times, most recently
from
786cd5d to
4ee6b72
Compare
…trics Signed-off-by: CYJiang <[email protected]>
googs1025
force-pushed
the
add/counter
branch
from
4ee6b72 to
41b7839
Compare
mayabar
requested changes
Dec 9, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
some additional comments
| nBuckets := len(buckets) | ||
| nCounts := len(counts) | ||
|
|
||
| for i := 0; i <= nBuckets; i++ { |
Collaborator
There was a problem hiding this comment.
Usually the counts array will be shorter than the buckets array, seems better to iterate till counts' length.
Comment on lines
+812
to
+814
| if i < nCounts { | ||
| count = counts[i] | ||
| } |
Collaborator
There was a problem hiding this comment.
in else of this if we can start this loop since got the end of the counts array
consider
if i>= nCounts {
break
}
.. use counts[i]
Comment on lines
254
to
+255
| // Each value will be passed to Observe() once at start-up. | ||
| // exactly once during initialization. Additionally: |
| switch { | ||
| case i == 0: | ||
| // First bucket: [0, buckets[0]] | ||
| lower = 0.0 |
Collaborator
There was a problem hiding this comment.
lower can be initialized before the loop + processing of the last bucket could be done after the loop - in this case no need for switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.