-
Notifications
You must be signed in to change notification settings - Fork 159
run ci only if [run-ci] is in commit message #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
With this requirement, we could also allow CI to run on pushes to branches, provided the [run-ci] tag is in the commit message. |
drreynolds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but can you clarify the purpose of the PR? Is it just that we run the CI too frequently and want to limit this? Or is this a "security" question?
|
We run CI too frequently and want to limit it, especially if we start hosting our own github runners. We can discuss this more at our next team meeting. For now, we should not merge this. I meant to open it as a draft. |
|
Ill also note that GitHub supports a skip ci command by default: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/skip-workflow-runs. We could use an opt-out approach instead. |
This will limit the GitHub actions CI to only commits with "[run-ci]" in the commit message. This will ensure we are not running the GitHub actions CI more than necessary.