[TOSA] Add transposed conv support #4360
Open
+188
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sahas3
reviewed
Nov 4, 2025
Member
sahas3
left a comment
sahas3
left a comment
There was a problem hiding this comment.
Change looks good to me. Some minor comments and clarifying questions.
Lower aten.conv_transpose2d into tosa.transpose_conv2d. Refresh FX importer TOSA xfails to drop the transpose-conv cases that now pass, and document the weight layout mapping. Change-Id: I709579e40a1ccaf9b9188392c7c78fcb653109ce
Lallapallooza
force-pushed
the
vit/add-transpose-convs-only
branch
from
f6e53b6 to
6db8cd6
Compare
sahas3
approved these changes
Nov 6, 2025
Member
sahas3
left a comment
sahas3
left a comment
There was a problem hiding this comment.
LG once you fix the issue about failure check after IR rewrites.
For future reference, it'll be good if you preserve the commits since it's easier to review what's changed since last time review was provided. We can squash commits during merge. Thanks!
Lazily create the NHWC input transpose so we emit it only once the failure guards in the transposed and depthwise convolution rewrite succeed. Change-Id: Ia362deda898794397107f6da3c44cd89f219f58f
Change-Id: I7eb03f6173a7779248a4ed14e1d9d1016b94ec79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower aten.conv_transpose2d into tosa.transpose_conv2d. Refresh FX importer TOSA xfails to drop the transpose-conv cases that now pass, and document the weight layout mapping.