Show endpoint and tips when emulator is already running#181
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes modify the post-start output flow to pass endpoint and web app URL information through the container start process. When containers are already running, message output switches to note-level severity with endpoint details emitted. The UI layer adds a new message handler to hide headers when note-severity messages are received. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| msgCopy := msg | ||
| line := styledLine{text: components.RenderMessage(msg), message: &msgCopy} | ||
| var cmd tea.Cmd | ||
| if msg.Severity == output.SeverityNote { |
There was a problem hiding this comment.
UX wise looks good 🧹
Question: This is going to hide the TUI header for all SeverityNote messages, not only in the case emulator is running. Is this expected @gtsiolis?
There was a problem hiding this comment.
Good point, @anisaoshafi. Now that the banner is more functional with plan and config path with #180, we can leave it as is for now. In the future we may add a boolean to hie the banner per case.
386ce82 to
2689ca1
Compare
| if running { | ||
| output.EmitInfo(sink, "LocalStack is already running") | ||
| output.EmitNote(sink, "LocalStack is already running") | ||
| resolvedHost, _ := endpoint.ResolveHost(c.Port, localStackHost) |
There was a problem hiding this comment.
We should check the result dnsOK of ResolveHost like we do line 227 in current file
2689ca1 to
6a8bd35
Compare
|
Thanks both, @anisaoshafi and @carole-lavillonniere! |
This will: