Skip to content

replace OpenAL with mojoAL (SDL3)#2310

Draft
choonarine wants to merge 1 commit into
love2d:mainfrom
choonarine:mojoal
Draft

replace OpenAL with mojoAL (SDL3)#2310
choonarine wants to merge 1 commit into
love2d:mainfrom
choonarine:mojoal

Conversation

@choonarine
Copy link
Copy Markdown

@choonarine choonarine commented Apr 22, 2026

  • I confirm that any code in this pull request that is not authored by me has proper attribution and licensing included, and that this pull request does not include any output from generative AI / LLM tools.

Description

MojoAL was recently updated and is now suitable for SDL3. I've tested some of the audio features and they work well.
I tested it on Windows 11, but unfortunately I don't have any Apple devices and was unable to test it on other iOS or macOS devices, so I'm unsure whether it works well on them.

I know it's a major change and unspecified errors can be caused by a lack of validation, so it may still be unstable.

However, if it is merged into the main branch, it will resolve the issues caused by the original OpenAL library (License issues, etc.), and OpenAL wrapper should be removed from megasource!

(note: sorry for my poor english ;( It's not my first language)

Related Issues

#1764

Copilot AI review requested due to automatic review settings April 22, 2026 14:01

This comment was marked as spam.

@choonarine
Copy link
Copy Markdown
Author

choonarine commented Apr 22, 2026

🤦🏼🤦🏼🤦🏼🤦🏼
I’ve been mostly working in a separate Git hosting service, so I didn’t realize GitHub had added this AI slop review feature... (and I CANNOT EVEN REMOVE those reviews myself)
If it’s at all possible, I’d really appreciate it if you could remove those reviews. I sincerely apologize for the inconvenience, and thank you very much in advance.

@slime73
Copy link
Copy Markdown
Member

slime73 commented Apr 22, 2026

Sorry, we don't have copilot enabled at all in the project so we're trying to figure out how to prevent this. It seems like it might be a new github "feature" to use it everywhere even when explicitly disabled...

@slime73
Copy link
Copy Markdown
Member

slime73 commented Apr 22, 2026

As for the change itself, we shouldn't unconditionally replace OpenAL Soft with MojoAL since many of love's audio APIs (such as effects) won't work with the latter. But adding a way to opt into using MojoAL when compiling love is fine, as long as it doesn't introduce regressions in the APIs it does support.

@choonarine choonarine marked this pull request as draft April 22, 2026 15:34
@choonarine
Copy link
Copy Markdown
Author

choonarine commented Apr 22, 2026

I’ll update this MojoAL PR to be optional as soon as possible.
I’ll work on improving compatibility with OpenAL APIs that are not fully supported in MojoAL where possible, though it may take some time.
Until then, I’ll leave this PR as a draft.

Thanks for the review! I’ll come back with a improved implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants