replace OpenAL with mojoAL (SDL3)#2310
Conversation
|
🤦🏼🤦🏼🤦🏼🤦🏼 |
|
Sorry, we don't have copilot enabled at all in the project so we're trying to figure out how to prevent this. It seems like it might be a new github "feature" to use it everywhere even when explicitly disabled... |
|
As for the change itself, we shouldn't unconditionally replace OpenAL Soft with MojoAL since many of love's audio APIs (such as effects) won't work with the latter. But adding a way to opt into using MojoAL when compiling love is fine, as long as it doesn't introduce regressions in the APIs it does support. |
|
I’ll update this MojoAL PR to be optional as soon as possible. Thanks for the review! I’ll come back with a improved implementation. |
Description
MojoAL was recently updated and is now suitable for SDL3. I've tested some of the audio features and they work well.
I tested it on Windows 11, but unfortunately I don't have any Apple devices and was unable to test it on other iOS or macOS devices, so I'm unsure whether it works well on them.
I know it's a major change and unspecified errors can be caused by a lack of validation, so it may still be unstable.
However, if it is merged into the main branch, it will resolve the issues caused by the original OpenAL library (License issues, etc.), and OpenAL wrapper should be removed from megasource!
(note: sorry for my poor english ;( It's not my first language)
Related Issues
#1764