-
Notifications
You must be signed in to change notification settings - Fork 35
Enable Tmux support for kitty #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your pull request. I believe that utilizing the unicode placeholder functionality would be beneficial. I have not yet been able to thoroughly examine the implementation details (or rather, kitty's unicode placeholder functionality), so I will need to check it later. |
This enables images in tmux.
The kitty unicode placeholder protocol does not change the aspect ratio when presenting images, this can lead to gaps between images
Autodetection does not match pregenerated images
This is much more reliable then checking for envars, especially if connected via SSH or tmux as the envars might be missing, and should work automatically with new terminals supporting the kitty protocol
|
@lusingander I would consider this quite ready and cleaner now, The scope got a bit bigger. I've rewrote the cell size code to have minimal size when drawing the image and calculate dimensions to match the previous behavior for a 1:2 image. I discovered that the envars for detecting terminal type might not be present on tmux and ssh session, so i changed the detection algo to query the underlying terminal directly if the kitty protocol is enabled using terminal escape codes. Ghostty detection now also works as expected, and any future terminals that support the protocol should work without modifications |
|
Thank you, I'm not sure if I can check it immediately, but I will. |
|
I haven't investigated it thoroughly, but it seems unstable regardless of tmux usage. |
|
Yes i noticed this as well, the issue is probably that all the images are re-transmitted on each update. It should keep a list of Or simpler send all the images for the current list view up front and then just send the the unicode chars referencing them, then resend the images when the list changes. Kitty caches up to 320mb of images it seems like so there is also the possibly to to send things in advance |
Thanks for a nice app, i work a lot in tmux so i took a stab at enabling serie in kitty
using the "Unicode placeholder" method.
Seems to work fine in kitty, ghostty seems to have some issues with placement. I don't know if
iterm has something equivalent to enable it there as well.
I just wanted se if you are interested in merging and some initial feedback in that case, currently the image tests are failing as the image sizes are now dependent cell size and differs depending on what font is used...