fix: Add missing fields of FrameworkRenderingTiming #179
Conversation
partholon
requested review from
SoonIter and
jianliang00
and removed request for
SoonIter and
jianliang00
docs/en/api/lynx-api/performance-api/framework-rendering-timing.mdx
Outdated
Show resolved
Hide resolved
partholon
force-pushed
the
p/partholon/pipeline_adapt_to_latest
branch
from
bbc86b1 to
58d5efa
Compare
partholon
requested review from
Huxpro and
Tamerlx
and removed request for
Tamerlx
|
@Huxpro please take a look at this PR, thank you! |
| setInitDataStart: number; | ||
| ``` | ||
|
|
||
| 根据[数据预处理函数（DataProcessor）](api/react/interface.dataprocessordefinition) 的结果更新模版初始数据开始的时间戳。该时间戳是一个表示为浮点型的 Unix 时间戳（单位：毫秒），精确到小数点后三位。例如：1739594612307.429。 |
There was a problem hiding this comment.
Avoid using "模版" which is legacy terminology
There was a problem hiding this comment.
removed 'base on the result of dataProcessor'. just describe the 'update init data' for setInitData and link to 'Using Data from Host Platform'.
docs/zh/api/lynx-api/performance-api/performance-entry/pipeline-entry.mdx
Outdated
Show resolved
Hide resolved
docs/zh/api/lynx-api/performance-api/framework-rendering-timing.mdx
Outdated
Show resolved
Hide resolved
| paintEnd: number; | ||
| ``` | ||
|
|
||
| 基于 UI 和 UITree，完成最终像素化的结束时间戳。该时间戳是一个表示为浮点型的 Unix 时间戳（单位：毫秒），精确到小数点后三位。例如：1739594612307.429。 |
There was a problem hiding this comment.
What is "UI" and "UI tree"? Find the proper definition in the Lynx spec and reference to them instead. (If the spec is broken, fix the spec)
There was a problem hiding this comment.
the original text is the description of paint in the spec. we modify the description of paintEnd to "the timestamp when the paint ends" and link "paint" to the spec.
|
The current spec only defined "framework rendering" as a concept:
Shall we make diagrams for 
|
partholon
force-pushed
the
p/partholon/pipeline_adapt_to_latest
branch
from
58d5efa to
d3aacbd
Compare
✅ Deploy Preview for lynx-doc ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
partholon
force-pushed
the
p/partholon/pipeline_adapt_to_latest
branch
from
d3aacbd to
dcf0587
Compare
Great suggestion, I will add a diagram for frameworkRenderingTiming in the open source website |
partholon
force-pushed
the
p/partholon/pipeline_adapt_to_latest
branch
from
dcf0587 to
c3a9e42
Compare
|
@Huxpro resolve comments and add a diagram and description of the role of frameworkrenderingtiming. ptal~ |
rename FrameworkPipelineTiming to FrameworkRenderingTiming add vmExecuteStart/End, dataProcessorStrart/End and setInitDataStart/End in FrameworkRenderingTiming. Change-Id: I94758afb6491967f02e944f546450b987753ff51
partholon
force-pushed
the
p/partholon/pipeline_adapt_to_latest
branch
from
c3a9e42 to
77cbbbc
Compare
3 participants
rename FrameworkPipelineTiming to FrameworkRenderingTiming
add vmExecuteStart/End, dataProcessorStrart/End and setInitDataStart/End in FrameworkRenderingTiming.
Change-Id: I94758afb6491967f02e944f546450b987753ff51