refactor: don't use sub-package to allow reuse #525
Conversation
Change-Id: Ia7ec87b28e1eea9f6ce1d69ab609f054bdfe286c
❌ Deploy Preview for lynx-doc failed. Why did it fail? →Built without sensitive environment variables
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the llms-postprocess plugin from a separate workspace package to an inline plugin within the main project, simplifying the project structure.
- Converted
@lynx-js/rspress-plugin-llms-postprocessfrom a workspace package to a local inline plugin - Removed the plugin from the pnpm workspace configuration
- Updated import paths to reference the local plugin directory
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rspress.config.ts | Updated import to reference local plugin file instead of npm package |
| pnpm-workspace.yaml | Removed plugins/* from workspace packages as plugin is now inline |
| plugins/llms-postprocess/postprocess.ts | Added new file containing markdown postprocessing logic for LLMs |
| plugins/llms-postprocess/package.json | Removed package.json as plugin is no longer a separate workspace package |
| plugins/llms-postprocess/index.ts | Added new plugin entry point with rspress plugin implementation |
| package.json | Removed workspace dependency reference for the plugin package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "*.{js,jsx,ts,tsx,md,mdx,json,yml,yaml,css,scss}": "prettier --write", | ||
| "*.{md,mdx}": "cspell lint -c cspell.json --no-must-find-files" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
The dependencies mdast-util-from-markdown, mdast-util-to-markdown, and @types/mdast that were previously declared in plugins/llms-postprocess/package.json are now missing after converting this plugin to an inline module. These dependencies need to be added to the root package.json file for the plugin code in plugins/llms-postprocess/postprocess.ts to work properly.
Add to dependencies or devDependencies:
"mdast-util-from-markdown": "2.0.2",
"mdast-util-to-markdown": "2.1.2",
"@types/mdast": "4.0.4"1 participant
Change-Id: Ia7ec87b28e1eea9f6ce1d69ab609f054bdfe286c