Skip to content

refactor: remove legacy example app#46

Merged
nickolas-dimitrakas merged 1 commit intomasterfrom
refactor/Remove-Legacy-Example-App
Jan 12, 2026
Merged

refactor: remove legacy example app#46
nickolas-dimitrakas merged 1 commit intomasterfrom
refactor/Remove-Legacy-Example-App

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Dec 19, 2025

Background

  • The SDK already uses Scene Graph architecture internally, and Roku has standardized on Scene Graph for years. The legacy example adds unnecessary maintenance overhead and can confuse developers about the recommended approach.

What Has Changed

  • Removed example-legacy-sdk/ directory
  • Simplified deploy-and-test.sh to only support Scene Graph example
  • Updated README.md to remove legacy example references

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

Reference Issue (For employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Dec 19, 2025
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner December 19, 2025 16:38
@nickolas-dimitrakas nickolas-dimitrakas changed the base branch from master to feat/media-content-time-spent-calculation December 19, 2025 16:47
@nickolas-dimitrakas nickolas-dimitrakas force-pushed the feat/media-content-time-spent-calculation branch from 9bfc9c2 to f8a1468 Compare December 23, 2025 00:01
jamesnrokt
jamesnrokt previously approved these changes Jan 5, 2026
Copy link
Copy Markdown
Collaborator

@jamesnrokt jamesnrokt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending changing the base branch and merging of #44

@nickolas-dimitrakas nickolas-dimitrakas changed the base branch from feat/media-content-time-spent-calculation to master January 12, 2026 21:45
@nickolas-dimitrakas nickolas-dimitrakas dismissed stale reviews from BrandonStalnaker and jamesnrokt January 12, 2026 21:45

The base branch was changed.

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the refactor/Remove-Legacy-Example-App branch from 7a17ce0 to 59e3812 Compare January 12, 2026 22:20
@nickolas-dimitrakas nickolas-dimitrakas force-pushed the refactor/Remove-Legacy-Example-App branch from 59e3812 to fb39fb6 Compare January 12, 2026 22:40
@nickolas-dimitrakas nickolas-dimitrakas force-pushed the refactor/Remove-Legacy-Example-App branch from fb39fb6 to 7a72318 Compare January 12, 2026 22:54
@nickolas-dimitrakas nickolas-dimitrakas merged commit 433c5bf into master Jan 12, 2026
1 check passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the refactor/Remove-Legacy-Example-App branch January 12, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants