fix: add 30s TTL to pMemoize sitemap cache#7
Open
mabdullahabid wants to merge 1 commit intoabd.devfrom
Open
Conversation
Without a maxAge, pMemoize caches the Notion sitemap indefinitely in warm serverless function instances (30-60min on Vercel). New pages published to Notion are invisible until all instances cold-start. Adding maxAge: 30_000 ensures the sitemap refreshes every 30s, matching the ISR revalidate: 10 cadence on [pageId].tsx.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New blog posts published to Notion take a long time to become accessible (showing
Page404) even after multiple visits.Root cause:
pMemoizeinlib/get-site-map.tshas nomaxAge, so it caches the Notion sitemap indefinitely in-process. Vercel keeps serverless function instances warm for 30-60 minutes. Any new Notion page published after a function instance boots is invisible to that instance until it cold-starts.Fix
Add
maxAge: 30_000(30 seconds) to thepMemoizecall. After 30 seconds, the sitemap cache expires and the next request fetches a fresh sitemap from Notion — picking up any newly published pages.Testing
abd.devbranchOne line diff. No other changes.