-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
KeePassXC, -devel: update to latest #29310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e3cc432 to
aa71d1b
Compare
aa71d1b to
dfa98b5
Compare
Which older macOS versions did it fail with? There is code in the Portfile to pin the deployment target to no newer than 14.0 so that the build errors requiring the use of ScreenCaptureKit don't occur. If it now does use ScreenCaptureKit then the code pinning deployment target is no longer needed and should be removed. |
|
Here's where they added support for ScreenCaptureKit: keepassxreboot/keepassxc#11428 There seems to be at least an intent for it to work on older systems that don't have ScreenCaptureKit. |
|
@contextnerror , see my comment on https://trac.macports.org/ticket/72178#comment:4 for how to update the patch |
|
Thanks for sending me in the right direction, I have updated the patches and have gotten stable and devel to build on both my 12 and 10.14 machine. I can try and send the MAC_OS_VERSION_12_3 change upstream if desired. Will squash commits once everything is confirmed as ok. |
b53338b to
d19564f
Compare
|
Upstream was not interested in any changes, which is not entirely surprising. |
|
Change looks good although I haven't tested. You'll have to wait for someone that can merge to do it. @reneeotten ? @ryandesign ? If this is still the case, you'll have to squash all the commits in a single one (and rebase?). |
44f0ad3 to
e65ad88
Compare
e65ad88 to
9958e3c
Compare
* patch value of MAC_OS_VERSION_12_3 to fix build on older systems * add ScreenCaptureKit to existing patches * create separate old_macos patch for devel version * make devel builds not marked as Release build type 2.7.10 adds restrictions on short custom word lists, this is not a bug. Behavior is changed in devel version. Closes: https://trac.macports.org/ticket/72178
|
New commit for 2.7.11 version and latest snapshot. Tested on 12.7.6 for both and 10.14 for the stable version. Confirmed build fails with Qt < 5.12 but I'm not sure if any new fundamental incompatibilities were introduced or they just didn't want to keep the checks |
2.7.10 adds restrictions on short custom word lists, this is not a bug. Behavior is changed in devel version.
Closes: https://trac.macports.org/ticket/72178
Description
This version is likely incompatible with older versions of macOS, I was unable to resolve the build failures related to ScreenCaptureKit. I was never sure if it was an issue with my portfile or upstream code.
Type(s)
Tested on
macOS 12.7.6 21H1320 x86_64
Command Line Tools 14.2.0.0.1.1668646533
Verification
Have you
port lint?sudo port test?sudo port -vst install?