pg-golang: no longer removes destroot default #29659
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://trac.macports.org/ticket/72395
Description
As described in Trac: The golang portgroup currently sets the destroot to {}, and also causes an error if the user has not otherwise set the destroot phase.
This seems to assume that packages configured with the portgroup don't have proper Makefiles that should be used with
make install DESTDIR=${destroot}. The error messages give guidance in the case that users are just relying on the default golang build.cmd.I believe that this change would not break any existing port, since any current port using the golang group has to have set the destroot phase. Any new port can then rely on a good makefile (if it exists), or can set their own destroot phase.
@mascguy is assigned to this ticket on Trac.
Type(s)
Tested on
macOS 26.0.1 25A362 arm64
Xcode 16.4 16F6
To test, I've used this change in a different branch to test a new port that I'd like to submit to MacPorts once the current destroot behavior has changed: https://github.com/exprez135/macports-ports/tree/add-senpai
Verification
Have you