-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add subport for Redis 8.2.2 (default), keep redis7 for LTS #29692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This update introduces Redis 8.2.2 as the new default redis subport while preserving Redis 7.4.2 as redis7 for long-term support and compatibility. Summary of changes: - Added subport redis @8.2.2 (latest OSS release) - Moved existing 7.4.2 definition into redis7 subport - Updated checksums and distfile metadata for Redis 8.2.2 - Unified shared build configuration and patches across both subports - Added conflicts valkey to prevent binary overlap - Retained legacy patches for redis7 only
databases/redis/Portfile
Outdated
| -latomic | ||
| } | ||
| # Global settings common to both subports | ||
| revision 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the revision field is specific to each port, so should be set in both subport separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
databases/redis/Portfile
Outdated
| size 3901854 | ||
|
|
||
| # Avoid co-install with valkey which ships same executables | ||
| conflicts valkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same for both subports and should thus be defined above in the main Portfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Move the `revision` field from the global scope into each subport (`redis` and `redis7`), since `revision` is specific to each port. Also move the `conflicts valkey` line to the main section, as it applies to both subports. No functional changes; this is a structural cleanup per review feedback.
This update introduces Redis 8.2.2 as the new default redis subport while preserving Redis 7.4.2 as redis7 for long-term support and compatibility.
Summary of changes:
Description
Type(s)
Tested on
macOS x.y
Xcode x.y / Command Line Tools x.y.z
Verification
Have you
port lint?sudo port test?sudo port -vst install?