poetry: add python 3.14 subport #30031
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macportsbot
added
type: enhancement
maintainer
maintainer: open
reneeotten
requested changes
Nov 12, 2025
python/poetry/Portfile
Outdated
| if {![variant_isset python310] && ![variant_isset python311] && ![variant_isset python312] } { | ||
| default_variants +python313 | ||
| if {![variant_isset python310] && ![variant_isset python311] && ![variant_isset python312] && ![variant_isset python313] } { | ||
| default_variants +python314 |
Contributor
There was a problem hiding this comment.
You should not change the default Python version yet, but only do so after the default has been changed in the python PortGroup which Josh typically does around January 1st as per the MacPorts' [policy](per the MacPorts' policy). Of course adding a py314 subport now is fine.
reneeotten
requested changes
Nov 14, 2025
python/poetry/Portfile
Outdated
| name poetry | ||
| version 2.2.1 | ||
| revision 0 | ||
| revision 1 |
Contributor
There was a problem hiding this comment.
Suggested change
| revision 1 | |
| revision 0 |
python/poetry/Portfile
Outdated
Comment on lines
30
to
33
| variant python310 conflicts python311 python312 python313 description {Use Python 3.10} {} | ||
| variant python311 conflicts python310 python312 python313 description {Use Python 3.11} {} | ||
| variant python312 conflicts python310 python311 python313 description {Use Python 3.12} {} | ||
| variant python313 conflicts python310 python311 python312 description {Use Python 3.13} {} |
Contributor
There was a problem hiding this comment.
these all need to conflict with python314
python/poetry/Portfile
Outdated
| variant python311 conflicts python310 python312 python313 description {Use Python 3.11} {} | ||
| variant python312 conflicts python310 python311 python313 description {Use Python 3.12} {} | ||
| variant python313 conflicts python310 python311 python312 description {Use Python 3.13} {} | ||
| variant python313 conflicts python310 python311 python312 description {Use Python 3.14} {} |
Contributor
There was a problem hiding this comment.
Suggested change
| variant python313 conflicts python310 python311 python312 description {Use Python 3.14} {} | |
| variant python314 conflicts python310 python311 python312 python313 description {Use Python 3.14} {} |
python/poetry/Portfile
Outdated
| } | ||
| } | ||
|
|
||
| python.pep517 yes |
Contributor
|
@dgilman thanks for the PR. I made the remaining changes myself and will merge the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type(s)
Tested on
macOS 15.4 24E248 x86_64
Xcode 16.3 16E140
Verification
Have you
port lint?sudo port test?sudo port -vst install?