Skip to content

Conversation

@JonathanTab
Copy link

A new port for https://github.com/pixop/video-compare.

Description

Video-compare. new port

Type(s)

Submission

  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.7.8 22H730 x86_64
Command Line Tools 14.3.1.0.1.1683849156

Verification

Have you

  • [ x] followed our Commit Message Guidelines?
  • [ x] squashed and minimized your commits?
  • [x ] checked that there aren't other open pull requests for the same change?
  • [x ] referenced existing tickets on Trac with full URL in commit message?
  • [x ] checked your Portfile with port lint?
  • [x ] tried existing tests with sudo port test?
  • [ x] tried a full install with sudo port -vst install?
  • [x ] tested basic functionality of all binary files?
  • [ x] checked that the Portfile's most important variants haven't been broken?

This Portfile defines the video-compare tool, including its dependencies and build instructions.
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the submission @JonathanTab - a few comments/suggestions to improve/get this to work correctly

updated to ffmpeg8, cleaned up, and simplified config.
Comment on lines +25 to +29
build.env-append {
CXXFLAGS="-I${prefix}/libexec/ffmpeg8/include"
LDFLAGS="-L${prefix}/libexec/ffmpeg8/lib"
PKG_CONFIG_PATH="${prefix}/libexec/ffmpeg8/lib/pkgconfig:${env(PKG_CONFIG_PATH)}"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the usual way would be to use:
configure.cxxflags-append, configure.ldflags-append, and configure.pkg_config_path-append
that would also retain whatever else is put in these flags already, either by MacPorts ifself or by the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants