fix(estimate_fee): should use charge_fee from config #889
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohiiit
approved these changes
Dec 5, 2025
byteZorvin
commented
Dec 10, 2025
Member
Author
byteZorvin
left a comment
byteZorvin
left a comment
There was a problem hiding this comment.
The bug was identified and it wasnt due to madara/blockifier but the custom account from starkpay where they handle txn versions differently.
In the above context, closing this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
The estimate_fee RPC method always sets charge_fee to false when creating execution flags, ignoring the node's charge_fee configuration.
Resolves: #NA
What is the new behavior?
The estimate_fee method now respects the charge_fee configuration from the node's validator parameters. The charge_fee value is passed through the RPC service and used when creating execution flags for fee estimation.
Does this introduce a breaking change?
No