queue: Move allocation out of mutex#44
Merged
Merged
Conversation
Qwinci
suggested changes
May 14, 2026
Qwinci
left a comment
Qwinci
left a comment
There was a problem hiding this comment.
LGTM apart from possibly a single minor style thing
avdgrinten
force-pushed
the
allocate-outside-locks
branch
from
5b557c0 to
53c28de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will forbid allocations inside spinlocks in the future in Managarm, so this PR moves the allocation in
async::queueout of the mutex (which is a spinlock in Thor).