Open
Conversation
mandatoryprogrammer
requested changes
Aug 11, 2017
Owner
mandatoryprogrammer
left a comment
mandatoryprogrammer
left a comment
There was a problem hiding this comment.
Great changes, just some quick questions.
| /etc/nginx/ssl/""" + hostname + """.crt; # Wildcard SSL certificate | ||
| /etc/nginx/ssl/""" + hostname + """.key; # Wildcard SSL key | ||
|
|
||
| Note: by default self-registration is enabled. You can disable this by changing the 'self_registration' option in the config file to |
There was a problem hiding this comment.
Question about this, wouldn't setting this to a no still make it enabled? no is a string which should be True-ish in Python right: if not settings['self_registration']:. Let me know if I'm missing something!
Author
There was a problem hiding this comment.
Yeah I would have thought so too, but it seems to work just fine. Yaml is a bit weird (I've never used it before personally), and I think PyYAML converts "yes/no" into Booleans (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values).
Author
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configuration option to enable/disable self-registration (requires restart of both api and gui servers).
Reconfigured API and GUI servers to listen only on localhost, rather than 0.0.0.0. (Nginx handles the app proxying to these servers anyway so there's no reason for them to be publicly accessible.)
Added some other entries to gitignore.