Skip to content

Conversation

@celestialaly
Copy link
Contributor

@celestialaly celestialaly commented Jul 31, 2025

Actual behavior

When we call the findOneBy method:

New behavior

Considering the fact that the cache key is specific enough (ex: oauth_mapado_rest_client__v1_customer_statuses?label=Etudiant&contract=%2Fv1%2Fcontracts%2F237&fields=id%2Clabel), I think we can allow null values in the cache.

@celestialaly celestialaly requested review from a team, JulienRAVIA, LedruRomane, badaz, bjulien, jdeniau, lnahiro and tdugue and removed request for a team July 31, 2025 09:10
Copy link
Contributor

@JulienRAVIA JulienRAVIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @celestialaly for your contribution 💪💪

@celestialaly celestialaly force-pushed the aa-feat-allow-cacheable-null branch from 35f7dae to 3158c07 Compare August 1, 2025 12:41
@celestialaly celestialaly merged commit b66d492 into main Aug 5, 2025
6 checks passed
@celestialaly celestialaly deleted the aa-feat-allow-cacheable-null branch August 5, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants