Open
Conversation
sheindel
reviewed
Jun 12, 2024
Contributor
|
Looks good to me! One other thing would be to do a version bump in package.json. I would do 0.3.0 instead of 0.2.1 because this does change some underlying implementation and could cause issues for people. |
Contributor
|
Looks great to me! @chriswhong if/when you have bandwidth, would you be able to merge these changes in? I'm not sure what the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for automatic detection of Date objects. Date objects will result in a field type of 'D'. Original code from @jeff-tenhave but json2dbf is updated to work with newer versions of node.